solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Deprecate useless wxWindow::GetDefaultBorderForControl()

Browse source 
This function was added back in a047aff270 (Added wxBORDER_THEME,
wxWindow::GetDefaultBorderForControl(), wxWindow::CanApplyThemeBorder(),
2007-08-07) but seems to have been made completely unnecessary by
dc797d8e1b (More border rationalisation. GetDefaultBorder is now mostly
defined in base class files., 2007-11-13) soon afterwards and never did
anything other than returning wxBORDER_THEME, with no explanation as to
when it might be useful to override it not to do it.

It also doesn't seem to be really used anywhere outside wxWidgets and
has never been documented, so make it non-virtual and deprecate it to
avoid confusion and simplify things.
This commit is contained in:
Vadim Zeitlin 2023-06-16 15:48:41 +01:00
parent f50fb719e8
commit a89577e8a4
5 changed files with 11 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/changes.txt
View file

@ -126,6 +126,10 @@ Changes in behaviour which may result in build errors
- wxTEST_DIALOG() macro now must be followed by semicolon, whereas previously
it was only supposed to, but it wasn't mandatory to use one after it.
- wxWindow::GetDefaultBorderForControl() is not virtual any longer and will
be completely removed in the future. If you overrode this function, don't
do it any longer. If you call it, replace it with wxBORDER_THEME constant.
3.3.0: (released 2022-??-??)
----------------------------