A better fix for installing cffi in Ubuntu 18.04 CI builds

Install its binary package from Ubuntu repositories directly instead of
installing libffi-dev to compile it ourselves later, as was done in the
previous commit. This is faster and also fixes the remaining problem in
the CI job using gcc 4.8 as this compiler can't be used to build cffi
because it uses -Wdate-time option incompatible with it.
This commit is contained in:
Vadim Zeitlin 2023-02-28 20:06:39 +01:00
parent 66a39d7230
commit 5f486a0806

View file

@ -156,14 +156,15 @@ jobs:
# Explanation for installing some less obvious packages:
# - coreutils contains nproc used in proc_count.sh called below.
# - libffi-dev is needed to build Python cffi module which is
# built as part of "pip install httpbin".
# - Python can't be installed using the action as usual because
# it installs an ABI-incompatible version, see (wrongly, IMO)
# closed https://github.com/actions/setup-python/issues/370
# - And python3-cffi can't be installed by pip because it can't
# be built from source with gcc 4.8 any longer (its build
# script uses -Wdate-time option unknown to this compiler).
# - xvfb is used for running the GUI tests.
apt-get update -qq
apt-get install -qq coreutils ${compiler-g++} git libffi-dev make pkg-config python3 python3-pip sudo xvfb
apt-get install -qq coreutils ${compiler-g++} git make pkg-config python3 python3-cffi python3-pip sudo xvfb
;;
'')