From 5f486a0806c471d2fe205d206be2dcfcd4d2d595 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Tue, 28 Feb 2023 20:06:39 +0100 Subject: [PATCH] A better fix for installing cffi in Ubuntu 18.04 CI builds Install its binary package from Ubuntu repositories directly instead of installing libffi-dev to compile it ourselves later, as was done in the previous commit. This is faster and also fixes the remaining problem in the CI job using gcc 4.8 as this compiler can't be used to build cffi because it uses -Wdate-time option incompatible with it. --- .github/workflows/ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0c72daeef8..962899a759 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -156,14 +156,15 @@ jobs: # Explanation for installing some less obvious packages: # - coreutils contains nproc used in proc_count.sh called below. - # - libffi-dev is needed to build Python cffi module which is - # built as part of "pip install httpbin". # - Python can't be installed using the action as usual because # it installs an ABI-incompatible version, see (wrongly, IMO) # closed https://github.com/actions/setup-python/issues/370 + # - And python3-cffi can't be installed by pip because it can't + # be built from source with gcc 4.8 any longer (its build + # script uses -Wdate-time option unknown to this compiler). # - xvfb is used for running the GUI tests. apt-get update -qq - apt-get install -qq coreutils ${compiler-g++} git libffi-dev make pkg-config python3 python3-pip sudo xvfb + apt-get install -qq coreutils ${compiler-g++} git make pkg-config python3 python3-cffi python3-pip sudo xvfb ;; '')