This is a combination of running clang-tidy with modernize-use-nullptr check for some ports (GTK, X11, OSX) and manual changes to the ports for which it couldn't be used easily (MSW, DFB) and also manually updating the docs. Also replace NULL with null or nullptr in the comments as this is more consistent with the use of nullptr in the code and makes it simpler to grep for the remaining occurrences of NULL itself. And also use null in the assert messages. Only a few occurrences of "NULL" are still left in non-C files, mostly corresponding to unclear comments or string output which it might not be safe to change.
188 lines
5.9 KiB
C++
188 lines
5.9 KiB
C++
///////////////////////////////////////////////////////////////////////////////
|
|
// Name: tests/controls/ownerdrawncomboboxtest.cpp
|
|
// Purpose: OwnerDrawnComboBox unit test
|
|
// Author: Jaakko Salli
|
|
// Created: 2010-12-17
|
|
// Copyright: (c) 2010 Jaakko Salli
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
// ----------------------------------------------------------------------------
|
|
// headers
|
|
// ----------------------------------------------------------------------------
|
|
|
|
#include "testprec.h"
|
|
|
|
#if wxUSE_ODCOMBOBOX
|
|
|
|
|
|
#ifndef WX_PRECOMP
|
|
#include "wx/app.h"
|
|
#endif // WX_PRECOMP
|
|
|
|
#include "wx/odcombo.h"
|
|
|
|
#include "textentrytest.h"
|
|
#include "itemcontainertest.h"
|
|
#include "testableframe.h"
|
|
|
|
// ----------------------------------------------------------------------------
|
|
// test class
|
|
// ----------------------------------------------------------------------------
|
|
|
|
class OwnerDrawnComboBoxTestCase : public TextEntryTestCase,
|
|
public ItemContainerTestCase,
|
|
public CppUnit::TestCase
|
|
{
|
|
public:
|
|
OwnerDrawnComboBoxTestCase() { }
|
|
|
|
virtual void setUp() override;
|
|
virtual void tearDown() override;
|
|
|
|
private:
|
|
virtual wxTextEntry *GetTestEntry() const override { return m_combo; }
|
|
virtual wxWindow *GetTestWindow() const override { return m_combo; }
|
|
|
|
virtual wxItemContainer *GetContainer() const override { return m_combo; }
|
|
virtual wxWindow *GetContainerWindow() const override { return m_combo; }
|
|
|
|
virtual void CheckStringSelection(const char * WXUNUSED(sel)) override
|
|
{
|
|
// do nothing here, as explained in TextEntryTestCase comment, our
|
|
// GetStringSelection() is the wxChoice, not wxTextEntry, one and there
|
|
// is no way to return the selection contents directly
|
|
}
|
|
|
|
CPPUNIT_TEST_SUITE( OwnerDrawnComboBoxTestCase );
|
|
wxTEXT_ENTRY_TESTS();
|
|
wxITEM_CONTAINER_TESTS();
|
|
CPPUNIT_TEST( Size );
|
|
CPPUNIT_TEST( PopDismiss );
|
|
CPPUNIT_TEST( Sort );
|
|
CPPUNIT_TEST( ReadOnly );
|
|
CPPUNIT_TEST_SUITE_END();
|
|
|
|
void Size();
|
|
void PopDismiss();
|
|
void Sort();
|
|
void ReadOnly();
|
|
|
|
wxOwnerDrawnComboBox *m_combo;
|
|
|
|
wxDECLARE_NO_COPY_CLASS(OwnerDrawnComboBoxTestCase);
|
|
};
|
|
|
|
wxREGISTER_UNIT_TEST_WITH_TAGS(OwnerDrawnComboBoxTestCase,
|
|
"[OwnerDrawnComboBoxTestCase][item-container]");
|
|
|
|
// ----------------------------------------------------------------------------
|
|
// test initialization
|
|
// ----------------------------------------------------------------------------
|
|
|
|
void OwnerDrawnComboBoxTestCase::setUp()
|
|
{
|
|
m_combo = new wxOwnerDrawnComboBox(wxTheApp->GetTopWindow(), wxID_ANY);
|
|
}
|
|
|
|
void OwnerDrawnComboBoxTestCase::tearDown()
|
|
{
|
|
delete m_combo;
|
|
m_combo = nullptr;
|
|
}
|
|
|
|
// ----------------------------------------------------------------------------
|
|
// tests themselves
|
|
// ----------------------------------------------------------------------------
|
|
|
|
void OwnerDrawnComboBoxTestCase::Size()
|
|
{
|
|
// under MSW changing combobox size is a non-trivial operation because of
|
|
// confusion between the size of the control with and without dropdown, so
|
|
// check that it does work as expected
|
|
|
|
const int heightOrig = m_combo->GetSize().y;
|
|
|
|
// check that the height doesn't change if we don't touch it
|
|
m_combo->SetSize(100, -1);
|
|
CPPUNIT_ASSERT_EQUAL( heightOrig, m_combo->GetSize().y );
|
|
|
|
// check that setting both big and small (but not too small, there is a
|
|
// limit on how small the control can become under MSW) heights works
|
|
m_combo->SetSize(-1, 50);
|
|
CPPUNIT_ASSERT_EQUAL( 50, m_combo->GetSize().y );
|
|
|
|
m_combo->SetSize(-1, 10);
|
|
CPPUNIT_ASSERT_EQUAL( 10, m_combo->GetSize().y );
|
|
|
|
// and also that restoring it works (this used to be broken before 2.9.1)
|
|
m_combo->SetSize(-1, heightOrig);
|
|
CPPUNIT_ASSERT_EQUAL( heightOrig, m_combo->GetSize().y );
|
|
}
|
|
|
|
void OwnerDrawnComboBoxTestCase::PopDismiss()
|
|
{
|
|
EventCounter drop(m_combo, wxEVT_COMBOBOX_DROPDOWN);
|
|
EventCounter close(m_combo, wxEVT_COMBOBOX_CLOSEUP);
|
|
|
|
m_combo->Popup();
|
|
m_combo->Dismiss();
|
|
|
|
CPPUNIT_ASSERT_EQUAL(1, drop.GetCount());
|
|
CPPUNIT_ASSERT_EQUAL(1, close.GetCount());
|
|
}
|
|
|
|
void OwnerDrawnComboBoxTestCase::Sort()
|
|
{
|
|
delete m_combo;
|
|
m_combo = new wxOwnerDrawnComboBox(wxTheApp->GetTopWindow(),
|
|
wxID_ANY, "",
|
|
wxDefaultPosition, wxDefaultSize,
|
|
0, nullptr,
|
|
wxCB_SORT);
|
|
|
|
m_combo->Append("aaa");
|
|
m_combo->Append("Aaa");
|
|
m_combo->Append("aba");
|
|
m_combo->Append("aaab");
|
|
m_combo->Append("aab");
|
|
m_combo->Append("AAA");
|
|
|
|
CPPUNIT_ASSERT_EQUAL("AAA", m_combo->GetString(0));
|
|
CPPUNIT_ASSERT_EQUAL("Aaa", m_combo->GetString(1));
|
|
CPPUNIT_ASSERT_EQUAL("aaa", m_combo->GetString(2));
|
|
CPPUNIT_ASSERT_EQUAL("aaab", m_combo->GetString(3));
|
|
CPPUNIT_ASSERT_EQUAL("aab", m_combo->GetString(4));
|
|
CPPUNIT_ASSERT_EQUAL("aba", m_combo->GetString(5));
|
|
|
|
m_combo->Append("a");
|
|
|
|
CPPUNIT_ASSERT_EQUAL("a", m_combo->GetString(0));
|
|
}
|
|
|
|
void OwnerDrawnComboBoxTestCase::ReadOnly()
|
|
{
|
|
wxArrayString testitems;
|
|
testitems.Add("item 1");
|
|
testitems.Add("item 2");
|
|
|
|
delete m_combo;
|
|
m_combo = new wxOwnerDrawnComboBox(wxTheApp->GetTopWindow(), wxID_ANY, "",
|
|
wxDefaultPosition, wxDefaultSize,
|
|
testitems,
|
|
wxCB_READONLY);
|
|
|
|
m_combo->SetValue("item 1");
|
|
|
|
CPPUNIT_ASSERT_EQUAL("item 1", m_combo->GetValue());
|
|
|
|
m_combo->SetValue("not an item");
|
|
|
|
CPPUNIT_ASSERT_EQUAL("item 1", m_combo->GetValue());
|
|
|
|
// Since this uses FindString it is case insensitive
|
|
m_combo->SetValue("ITEM 2");
|
|
|
|
CPPUNIT_ASSERT_EQUAL("item 2", m_combo->GetValue());
|
|
}
|
|
|
|
#endif // wxUSE_ODCOMBOBOX
|