This is a combination of running clang-tidy with modernize-use-nullptr check for some ports (GTK, X11, OSX) and manual changes to the ports for which it couldn't be used easily (MSW, DFB) and also manually updating the docs. Also replace NULL with null or nullptr in the comments as this is more consistent with the use of nullptr in the code and makes it simpler to grep for the remaining occurrences of NULL itself. And also use null in the assert messages. Only a few occurrences of "NULL" are still left in non-C files, mostly corresponding to unclear comments or string output which it might not be safe to change.
333 lines
12 KiB
C++
333 lines
12 KiB
C++
///////////////////////////////////////////////////////////////////////////////
|
|
// Name: tests/formatconverter/formatconverter.cpp
|
|
// Purpose: Test wxFormatConverter
|
|
// Author: Mike Wetherell
|
|
// Copyright: (c) 2004 Mike Wetherell
|
|
// Licence: wxWindows licence
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
//
|
|
// Notes:
|
|
//
|
|
// The conversions wxFormatConverter currently does are as follows:
|
|
//
|
|
// %s, %lS -> %ls
|
|
// %S, %hS -> %s
|
|
// %c, %lC -> %lc
|
|
// %C, %hC -> %c
|
|
//
|
|
// %hs and %hc stay the same.
|
|
//
|
|
// %S and %C aren't actually in the ISO C or C++ standards, but they can be
|
|
// avoided when writing portable code.
|
|
//
|
|
// Nor are %hs or %hc in the standards, which means wxWidgets currently doesn't
|
|
// have a specifier for 'char' types that is ok for all builds and platforms.
|
|
//
|
|
// The effect of using %hs/%hc is undefined, though RTLs are quite likely
|
|
// to just ignore the 'h', so maybe it works as required even though it's
|
|
// not legal.
|
|
//
|
|
// I've put in some checks, such as this which will flag up any platforms
|
|
// where this is not the case:
|
|
//
|
|
// CPPUNIT_ASSERT(wxString::Format(wxT("%hs"), "test") == wxT("test"));
|
|
//
|
|
|
|
// For compilers that support precompilation, includes "wx/wx.h".
|
|
#include "testprec.h"
|
|
|
|
|
|
// for all others, include the necessary headers
|
|
#ifndef WX_PRECOMP
|
|
#include "wx/wx.h"
|
|
#endif
|
|
|
|
|
|
using CppUnit::TestCase;
|
|
using std::string;
|
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
// The test case
|
|
//
|
|
// wxFormatConverter only changes %s, %c, %S and %C, all others are treated
|
|
// equally, therefore it is enough to choose just one other for testing, %d
|
|
// will do.
|
|
|
|
class FormatConverterTestCase : public TestCase
|
|
{
|
|
CPPUNIT_TEST_SUITE(FormatConverterTestCase);
|
|
CPPUNIT_TEST(format_d);
|
|
CPPUNIT_TEST(format_hd);
|
|
CPPUNIT_TEST(format_ld);
|
|
CPPUNIT_TEST(format_s);
|
|
CPPUNIT_TEST(format_hs);
|
|
CPPUNIT_TEST(format_ls);
|
|
CPPUNIT_TEST(format_c);
|
|
CPPUNIT_TEST(format_hc);
|
|
CPPUNIT_TEST(format_lc);
|
|
CPPUNIT_TEST(format_S);
|
|
CPPUNIT_TEST(format_hS);
|
|
CPPUNIT_TEST(format_lS);
|
|
CPPUNIT_TEST(format_C);
|
|
CPPUNIT_TEST(format_hC);
|
|
CPPUNIT_TEST(format_lC);
|
|
CPPUNIT_TEST(testLonger);
|
|
CPPUNIT_TEST_SUITE_END();
|
|
|
|
void format_d();
|
|
void format_hd();
|
|
void format_ld();
|
|
void format_s();
|
|
void format_hs();
|
|
void format_ls();
|
|
void format_c();
|
|
void format_hc();
|
|
void format_lc();
|
|
|
|
void format_S();
|
|
void format_hS();
|
|
void format_lS();
|
|
void format_C();
|
|
void format_hC();
|
|
void format_lC();
|
|
void testLonger();
|
|
|
|
void doTest(const char *input, const char *expectedScanf,
|
|
const char *expectedUtf8,
|
|
const char *expectedWcharUnix,
|
|
const char *expectedWcharWindows);
|
|
void check(const wxString& input, const wxString& expectedScanf,
|
|
const wxString& expectedUtf8,
|
|
const wxString& expectedWcharUnix,
|
|
const wxString& expectedWcharWindows);
|
|
};
|
|
|
|
void FormatConverterTestCase::format_d()
|
|
{
|
|
doTest("d", "d", "d", "d", "d");
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%d"), 255) == wxT("255"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%05d"), 255) == wxT("00255"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("% 5d"), 255) == wxT(" 255"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("% 5d"), -255) == wxT(" -255"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%-5d"), -255) == wxT("-255 "));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%+5d"), 255) == wxT(" +255"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%*d"), 5, 255) == wxT(" 255"));
|
|
}
|
|
|
|
void FormatConverterTestCase::format_hd()
|
|
{
|
|
doTest("hd", "hd", "hd", "hd", "hd");
|
|
short s = 32767;
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%hd"), s) == wxT("32767"));
|
|
}
|
|
|
|
void FormatConverterTestCase::format_ld()
|
|
{
|
|
doTest("ld", "ld", "ld", "ld", "ld");
|
|
long l = 2147483647L;
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%ld"), l) == wxT("2147483647"));
|
|
}
|
|
|
|
void FormatConverterTestCase::format_s()
|
|
{
|
|
doTest("s", "ls", "s", "ls", "s");
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%s!"), wxT("test")) == wxT("test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%6s!"), wxT("test")) == wxT(" test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%-6s!"), wxT("test")) == wxT("test !"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%.6s!"), wxT("test")) == wxT("test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%6.4s!"), wxT("testing")) == wxT(" test!"));
|
|
}
|
|
|
|
void FormatConverterTestCase::format_hs()
|
|
{
|
|
doTest("hs", "hs", "s", "ls", "s");
|
|
CPPUNIT_ASSERT(wxString::Format(wxString(wxT("%hs!")), "test") == wxT("test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxString(wxT("%6hs!")), "test") == wxT(" test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxString(wxT("%-6hs!")), "test") == wxT("test !"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxString(wxT("%.6hs!")), "test") == wxT("test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxString(wxT("%6.4hs!")), "testing") == wxT(" test!"));
|
|
}
|
|
|
|
void FormatConverterTestCase::format_ls()
|
|
{
|
|
doTest("ls", "ls", "s", "ls", "s");
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%ls!"), L"test") == wxT("test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%6ls!"), L"test") == wxT(" test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%-6ls!"), L"test") == wxT("test !"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%.6ls!"), L"test") == wxT("test!"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%6.4ls!"), L"testing") == wxT(" test!"));
|
|
}
|
|
|
|
void FormatConverterTestCase::format_c()
|
|
{
|
|
doTest("c", "lc", "lc", "lc", "c");
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%c"), wxT('x')) == wxT("x"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%2c"), wxT('x')) == wxT(" x"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%-2c"), wxT('x')) == wxT("x "));
|
|
}
|
|
|
|
void FormatConverterTestCase::format_hc()
|
|
{
|
|
doTest("hc", "hc", "lc", "lc", "c");
|
|
CPPUNIT_ASSERT(wxString::Format(wxString(wxT("%hc")), 'x') == wxT("x"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxString(wxT("%2hc")), 'x') == wxT(" x"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxString(wxT("%-2hc")), 'x') == wxT("x "));
|
|
}
|
|
|
|
void FormatConverterTestCase::format_lc()
|
|
{
|
|
doTest("lc", "lc", "lc", "lc", "c");
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%lc"), L'x') == wxT("x"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%2lc"), L'x') == wxT(" x"));
|
|
CPPUNIT_ASSERT(wxString::Format(wxT("%-2lc"), L'x') == wxT("x "));
|
|
}
|
|
|
|
|
|
void FormatConverterTestCase::format_S()
|
|
{ doTest("S", "s", "s", "ls", "s"); }
|
|
void FormatConverterTestCase::format_hS()
|
|
{ doTest("hS", "s", "s", "ls", "s"); }
|
|
void FormatConverterTestCase::format_lS()
|
|
{ doTest("lS", "ls", "s", "ls", "s"); }
|
|
|
|
void FormatConverterTestCase::format_C()
|
|
{ doTest("C", "c", "lc", "lc", "c"); }
|
|
void FormatConverterTestCase::format_hC()
|
|
{ doTest("hC", "c", "lc", "lc", "c"); }
|
|
void FormatConverterTestCase::format_lC()
|
|
{ doTest("lC", "lc", "lc", "lc", "c"); }
|
|
|
|
// It's possible that although a format converts correctly alone, it leaves
|
|
// the converter in a bad state that will affect subsequent formats, so
|
|
// check with a selection of longer patterns.
|
|
//
|
|
void FormatConverterTestCase::testLonger()
|
|
{
|
|
struct {
|
|
const char *input;
|
|
const char *expectedScanf;
|
|
const char *expectedWcharUnix;
|
|
const char *expectedWcharWindows;
|
|
const char *expectedUtf8;
|
|
} formats[] = {
|
|
{ "%d", "%d", "%d", "%d", "%d" },
|
|
{ "%*hd", "%*hd", "%*hd", "%*hd", "%*hd" },
|
|
{ "%.4ld", "%.4ld", "%.4ld", "%.4ld", "%.4ld" },
|
|
{ "%-.*s", "%-.*ls", "%-.*ls", "%-.*s", "%-.*s" },
|
|
{ "%.*hs", "%.*hs", "%.*ls", "%.*s", "%.*s" },
|
|
{ "%-.9ls", "%-.9ls", "%-.9ls", "%-.9s", "%-.9s" },
|
|
{ "%-*c", "%-*lc", "%-*lc", "%-*c", "%-*lc" },
|
|
{ "%3hc", "%3hc", "%3lc", "%3c", "%3lc" },
|
|
{ "%-5lc", "%-5lc", "%-5lc", "%-5c", "%-5lc" }
|
|
};
|
|
size_t i, j;
|
|
|
|
// test all possible pairs of the above patterns
|
|
for (i = 0; i < WXSIZEOF(formats); i++) {
|
|
if (formats[i].input) {
|
|
wxString input(formats[i].input);
|
|
wxString expectedScanf(formats[i].expectedScanf);
|
|
wxString expectedUtf8(formats[i].expectedUtf8);
|
|
wxString expectedWcharUnix(formats[i].expectedWcharUnix);
|
|
wxString expectedWcharWindows(formats[i].expectedWcharWindows);
|
|
|
|
for (j = 0; j < WXSIZEOF(formats); j++)
|
|
if (formats[j].input)
|
|
check(input + formats[j].input,
|
|
expectedScanf + formats[j].expectedScanf,
|
|
expectedUtf8 + formats[j].expectedUtf8,
|
|
expectedWcharUnix + formats[j].expectedWcharUnix,
|
|
expectedWcharWindows + formats[j].expectedWcharWindows);
|
|
}
|
|
}
|
|
}
|
|
|
|
void FormatConverterTestCase::doTest(const char *input,
|
|
const char *expectedScanf,
|
|
const char *expectedUtf8,
|
|
const char *expectedWcharUnix,
|
|
const char *expectedWcharWindows)
|
|
{
|
|
static const wxChar *flag_width[] =
|
|
{ wxT(""), wxT("*"), wxT("10"), wxT("-*"), wxT("-10"), nullptr };
|
|
static const wxChar *precision[] =
|
|
{ wxT(""), wxT(".*"), wxT(".10"), nullptr };
|
|
static const wxChar *empty[] =
|
|
{ wxT(""), nullptr };
|
|
|
|
// no precision for %c or %C
|
|
const wxChar **precs = wxTolower(input[wxStrlen(input)-1]) == wxT('c') ?
|
|
empty : precision;
|
|
|
|
wxString fmt(wxT("%"));
|
|
|
|
// try the test for a variety of combinations of flag, width and precision
|
|
for (const wxChar **prec = precs; *prec; prec++)
|
|
for (const wxChar **width = flag_width; *width; width++)
|
|
check(fmt + *width + *prec + input,
|
|
fmt + *width + *prec + expectedScanf,
|
|
fmt + *width + *prec + expectedUtf8,
|
|
fmt + *width + *prec + expectedWcharUnix,
|
|
fmt + *width + *prec + expectedWcharWindows);
|
|
}
|
|
|
|
void FormatConverterTestCase::check(const wxString& input,
|
|
const wxString& expectedScanf,
|
|
const wxString& expectedUtf8,
|
|
const wxString& expectedWcharUnix,
|
|
const wxString& expectedWcharWindows)
|
|
{
|
|
// all of them are unused in some build configurations
|
|
wxUnusedVar(expectedScanf);
|
|
wxUnusedVar(expectedUtf8);
|
|
wxUnusedVar(expectedWcharUnix);
|
|
wxUnusedVar(expectedWcharWindows);
|
|
|
|
wxString result, msg;
|
|
|
|
#ifndef __WINDOWS__
|
|
// on windows, wxScanf() string needs no modifications
|
|
result = wxScanfConvertFormatW(input.wc_str());
|
|
|
|
msg = wxT("input: '") + input +
|
|
wxT("', result (scanf): '") + result +
|
|
wxT("', expected: '") + expectedScanf + wxT("'");
|
|
CPPUNIT_ASSERT_MESSAGE(string(msg.mb_str()), result == expectedScanf);
|
|
#endif // !__WINDOWS__
|
|
|
|
#if wxUSE_UNICODE_UTF8
|
|
result = (const char*)wxFormatString(input);
|
|
|
|
msg = wxT("input: '") + input +
|
|
wxT("', result (UTF-8): '") + result +
|
|
wxT("', expected: '") + expectedUtf8 + wxT("'");
|
|
CPPUNIT_ASSERT_MESSAGE(string(msg.mb_str()), result == expectedUtf8);
|
|
#endif // wxUSE_UNICODE_UTF8
|
|
|
|
#if wxUSE_UNICODE && !wxUSE_UTF8_LOCALE_ONLY
|
|
result = (const wchar_t*)wxFormatString(input);
|
|
|
|
#if defined(__WINDOWS__) && \
|
|
!defined(__CYGWIN__) && \
|
|
!defined(__MINGW32__)
|
|
wxString expectedWchar(expectedWcharWindows);
|
|
#else
|
|
wxString expectedWchar(expectedWcharUnix);
|
|
#endif
|
|
|
|
msg = wxT("input: '") + input +
|
|
wxT("', result (wchar_t): '") + result +
|
|
wxT("', expected: '") + expectedWchar + wxT("'");
|
|
CPPUNIT_ASSERT_MESSAGE(string(msg.mb_str()), result == expectedWchar);
|
|
#endif // wxUSE_UNICODE && !wxUSE_UTF8_LOCALE_ONLY
|
|
}
|
|
|
|
|
|
// register in the unnamed registry so that these tests are run by default
|
|
CPPUNIT_TEST_SUITE_REGISTRATION(FormatConverterTestCase);
|
|
|
|
// also include in its own registry so that these tests can be run alone
|
|
CPPUNIT_TEST_SUITE_NAMED_REGISTRATION(FormatConverterTestCase,
|
|
"FormatConverterTestCase");
|
|
|