Make the wxString(std::string_view) constructor explicit.
Otherwise, when comparing a std::string_view with a const char *, the
cast to wxString will be considered as a candidate for the comparison,
ultimately causing an "ambiguous overload for 'operator=='" error.
For example, this sample only builds if the constructor is explicit:
#include <wx/string.h>
#include <string_view>
int main() {
std::string_view view = "abc";
const char *str = "abc";
return view == str;
}
However, making the constructor explicit will break assignment:
std::string_view view = "abc";
wxString s;
s = view; // Error: no match for "operator="
That we can fix by implementing operator=(std::string_view)
That, however, introduces another ambiguity:
std::string str = "abc";
wxString s;
s = str; // Ambiguous between s = wxString(str)
and s = std::string_view(str)
That we can fix by implementing operator=(std::string)
Finally, note that some rather obscure ambiguities remain, such as:
wxString s;
s = {"abc", 2}; // Ambiguous between s = wxString("abc", 2)
and s = std::string_view("abc", 2)
Avoiding them is not simple (https://cplusplus.github.io/LWG/issue2946)
and doesn't add much value.
Closes #23834.
|
||
|---|---|---|
| .circleci | ||
| .github | ||
| 3rdparty | ||
| art | ||
| build | ||
| demos | ||
| distrib | ||
| docs | ||
| include | ||
| interface | ||
| lib | ||
| locale | ||
| misc | ||
| samples | ||
| src | ||
| tests | ||
| utils | ||
| .cirrus.yml | ||
| .editorconfig | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .mailmap | ||
| acinclude.m4 | ||
| aclocal.m4 | ||
| appveyor.yml | ||
| autoconf_inc.m4 | ||
| autogen.sh | ||
| CMakeLists.txt | ||
| config.guess | ||
| config.sub | ||
| configure | ||
| configure.ac | ||
| descrip.mms | ||
| install-sh | ||
| Makefile.in | ||
| mkinstalldirs | ||
| README-GIT.md | ||
| README.md | ||
| regen | ||
| setup.h.in | ||
| setup.h_vms | ||
| version-script.in | ||
| wx-config-inplace.in | ||
| wx-config.in | ||
| wxwidgets.props | ||
| wxwin.m4 | ||
About
wxWidgets is a free and open source cross-platform C++ framework for writing advanced GUI applications using native controls.
wxWidgets allows you to write native-looking GUI applications for all the major desktop platforms and also helps with abstracting the differences in the non-GUI aspects between them. It is free for the use in both open source and commercial applications, comes with the full, easy to read and modify, source and extensive documentation and a collection of more than a hundred examples. You can learn more about wxWidgets at https://www.wxwidgets.org/ and read its documentation online at https://docs.wxwidgets.org/
Platforms
This version of wxWidgets supports the following primary platforms:
- Windows 7, 8, 10 and 11 (32/64 bits).
- Most Unix variants using the GTK+ toolkit (version 2.6 or newer or 3.x).
- macOS (10.10 or newer) using Cocoa under both amd64 and ARM platforms.
All C++11 compilers are supported including but not limited to:
- Microsoft Visual C++ 2015 or later (up to 2022).
- g++ 4.8 or later (up to 13), including MinGW/MinGW-64/TDM under Windows.
- Clang (up to 16).
Please use 3.2 branch if you must use wxWidgets with a C++98 compiler or support Windows XP.
Licence
wxWidgets licence is a modified version of LGPL explicitly allowing not distributing the sources of an application using the library even in the case of static linking.
Building
For building the library, please see platform-specific documentation under
docs/<port> directory, e.g. here are the instructions for
wxGTK, wxMSW and
wxOSX.
If you're building the sources checked out from Git, and not from a released version, please see these additional Git-specific notes.
Further information
If you are looking for community support, you can get it from
- Mailing Lists
- Discussion Forums
- #wxwidgets IRC channel
- Stack Overflow
(tag your questions with
wxwidgets) - And you can report bugs at GitHub
Commercial support is also available.
Finally, keep in mind that wxWidgets is an open source project collaboratively developed by its users and your contributions to it are always welcome. Please check our guidelines if you'd like to do it.
Have fun!
The wxWidgets Team.
