solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Fix harmless warning about unused variable in wxMSW wxMenu

Browse source 
A variable was unused in wxDEBUG_LEVEL==0 build and assigning to it resulted
in a warning. Fix this by not defining this variable at all, which also makes
the check more clear.
This commit is contained in:
Vadim Zeitlin 2015-10-16 17:05:37 +02:00
parent 5cfaf2f898
commit ecdc7c3442
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/msw/menu.cpp
View file

@ -738,10 +738,12 @@ wxMenuItem *wxMenu::DoRemove(wxMenuItem *item)
// Update indices of radio groups.
if ( m_radioData )
{
bool inExistingGroup = m_radioData->UpdateOnRemoveItem(pos);
wxASSERT_MSG( !inExistingGroup || item->GetKind() == wxITEM_RADIO,
wxT("Removing non radio button from radio group?") );
if ( m_radioData->UpdateOnRemoveItem(pos) )
{
wxASSERT_MSG( item->GetKind() == wxITEM_RADIO,
wxT("Removing non radio button from radio group?") );
}
//else: item being removed is not in a radio group
}
// remove the item from the menu