solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Optimize wxTextCtrl::GetLastPosition()

Browse source 
It's better to call one API instead of four.
This commit is contained in:
Artur Wieczorek 2017-09-01 09:03:21 +02:00
parent 4fc8753285
commit c51dd81db6
1 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/msw/textctrl.cpp
View file

@ -1334,12 +1334,19 @@ wxTextPos wxTextCtrl::GetLastPosition() const
{
if ( IsMultiLine() )
{
int numLines = GetNumberOfLines();
long posStartLastLine = XYToPosition(0, numLines - 1);
long lenLastLine = GetLengthOfLineContainingPos(posStartLastLine);
return posStartLastLine + lenLastLine;
#if wxUSE_RICHEDIT
if ( IsRich() )
{
GETTEXTLENGTHEX gtl;
gtl.flags = GTL_NUMCHARS | GTL_PRECISE;
gtl.codepage = GetRichVersion() > 1 ? 1200 : CP_ACP;
return ::SendMessage(GetHwnd(), EM_GETTEXTLENGTHEX, (WPARAM)&gtl, 0);
}
else
#endif // wxUSE_RICHEDIT
{
return ::GetWindowTextLength(GetHwnd());
}
}
return wxTextEntry::GetLastPosition();