solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Get rid of IsLive() helper in wxSplitterWindow code

Browse source 
This was useful when we had AlwaysUsesLiveResize() and the related
complications, but now that live resizing is governed solely by
wxSP_LIVE_UPDATE again, it's not needed any longer.

No real changes.
This commit is contained in:
Vadim Zeitlin 2024-02-12 22:27:25 +01:00
parent 7584c04ff8
commit c4658ec8f2
1 changed files with 6 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/generic/splitter.cpp
View file

@ -69,15 +69,6 @@ wxBEGIN_EVENT_TABLE(wxSplitterWindow, wxWindow)
#endif // wxMSW
wxEND_EVENT_TABLE()
static bool IsLive(wxSplitterWindow* wnd)
{
// with wxSP_LIVE_UPDATE style the splitter windows are always resized
// following the mouse movement while it drags the sash, without it we only
// draw the sash at the new position but only resize the windows when the
// dragging is finished
return wnd->HasFlag(wxSP_LIVE_UPDATE);
}
static wxBitmap wxPaneCreateStippleBitmap()
{
// Notice that wxOverlay, under wxMSW, uses the wxBLACK colour i.e.(0,0,0)
@ -239,7 +230,11 @@ void wxSplitterWindow::OnMouseEvent(wxMouseEvent& event)
return;
}
bool isLive = IsLive(this);
// with wxSP_LIVE_UPDATE style the splitter windows are always resized
// following the mouse movement while it drags the sash, without it we only
// draw the sash at the new position but only resize the windows when the
// dragging is finished
const bool isLive = HasFlag(wxSP_LIVE_UPDATE);
if (event.LeftDown())
{
@ -414,7 +409,7 @@ void wxSplitterWindow::OnMouseCaptureLost(wxMouseCaptureLostEvent& WXUNUSED(even
SetCursor(* wxSTANDARD_CURSOR);
// Erase sash tracker
if ( !IsLive(this) )
if ( HasFlag(wxSP_LIVE_UPDATE) )
{
m_overlay.Reset();
}