solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Ensure CMake tests don't fail due to -Werror being used

Browse source 
Disable warnings while compiling the tests to avoid unnecessary noise in
the CMake output/error files (because we don't really care about
warnings in the test code at all) and also, and more importantly, to
ensure that the tests don't fail even when -Werror is specified in the
CMAKE_CXX_FLAGS globally, as it may happen when wxWidgets is used via
add_subdirectory() from a superproject.

See #23665.
This commit is contained in:
Vadim Zeitlin 2023-06-23 19:17:33 +02:00
parent f072544bd5
commit b882eb96c3
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
build/cmake/setup.cmake
View file

@ -82,6 +82,12 @@ if(wxBUILD_SHARED)
endif()
endif() # wxBUILD_SHARED
if(MSVC)
set(DISABLE_ALL_WARNINGS "/w")
else()
set(DISABLE_ALL_WARNINGS "-w")
endif()
# wx_check_cxx_source_compiles(<code> <var> [headers...])
function(wx_check_cxx_source_compiles code res_var)
set(src)
@ -96,7 +102,12 @@ function(wx_check_cxx_source_compiles code res_var)
endif()
endforeach()
set(src "${src}\n\nint main(int argc, char* argv[]) {\n ${code}\nreturn 0; }")
# We're not interested in any warnings that can arise in the test, which is
# especially important if -Werror is globally in effect.
cmake_push_check_state()
set(CMAKE_REQUIRED_FLAGS ${DISABLE_ALL_WARNINGS})
check_cxx_source_compiles("${src}" ${res_var})
cmake_pop_check_state()
endfunction()
# wx_check_cxx_source_compiles(<code> <var> [headers...])