solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Avoid deprecation warnings due to recent wxPropertyGrid changes

Browse source 
Rename the new overload of DoSetSplitterPosition() to use a different
name: not only this avoids deprecation warnings that broke all the CI
builds, but it also makes things more clear and simpler to use as all
the derived classes don't need to override both the deprecated overload
and the new one to avoid warnings about hiding a base class virtual
function and can just override the new one.

Also remove the default value "Refresh" for the flags which seems to be
inconsistent with the default value "Null" used elsewhere and prefer to
specify it explicitly.
This commit is contained in:
Vadim Zeitlin 2023-02-19 23:34:57 +01:00
parent 74e599df7b
commit b4ab8de248
8 changed files with 44 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

8
include/wx/propgrid/propgrid.h
View file

@ -956,7 +956,7 @@ public:
// than desired splitter position, especially when sizers are being used.
void SetSplitterPosition( int newXPos, int col = 0 )
{
DoSetSplitterPosition(newXPos, col, wxPGSplitterPositionFlags::Refresh);
DoSetSplitter(newXPos, col, wxPGSplitterPositionFlags::Refresh);
}
// Sets the property sorting function.
@ -1774,9 +1774,9 @@ protected:
void DoSetSelection( const wxArrayPGProperty& newSelection,
wxPGSelectPropertyFlags selFlags = wxPGSelectPropertyFlags::Null );
void DoSetSplitterPosition( int newxpos,
int splitterIndex = 0,
wxPGSplitterPositionFlags flags = wxPGSplitterPositionFlags::Refresh );
void DoSetSplitter( int newxpos,
int splitterIndex = 0,
wxPGSplitterPositionFlags flags = wxPGSplitterPositionFlags::Refresh );
bool DoAddToSelection( wxPGProperty* prop,
wxPGSelectPropertyFlags selFlags = wxPGSelectPropertyFlags::Null );