solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Fix more compatibility problems in C++17 wxString::ToLong()

Browse source 
Unlike the traditional C functions, std::from_chars() doesn't skip
leading whitespace and doesn't accept the leading "+" sign, so we need
to skip them explicitly to preserve the behaviour of ToLong() in the
previous wxWidgets versions.
This commit is contained in:
Vadim Zeitlin 2023-10-31 00:04:27 +01:00
parent 8d6a722ed8
commit ae2b05be5c
2 changed files with 20 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/strings/strings.cpp
View file

@ -580,6 +580,9 @@ static const struct ToLongData
{ wxT("-1"), -1, Number_Signed | Number_Long },
// this is surprising but consistent with strtoul() behaviour
{ wxT("-1"), (TestValue_t)ULONG_MAX, Number_Unsigned | Number_Long },
// a couple of edge cases
{ wxT(" +1"), 1, Number_Ok },
{ wxT(" -1"), (TestValue_t)ULONG_MAX, Number_Unsigned | Number_Long },
// this must overflow, even with 64 bit long
{ wxT("922337203685477580711"), 0, Number_Invalid },