From a157327207998e6adae17738b26186629fb7cc7d Mon Sep 17 00:00:00 2001 From: Mark Harfouche Date: Sun, 10 Jul 2022 08:37:02 -0400 Subject: [PATCH] Fix wxrc installation under macOS Run install_name_tool on wxrc binary again: this used to be done and is still needed, but was broken in 30915c6163 (Make wxrc independent from GUI support, 2021-07-07) which moved the code appending the line calling install_name_tool for wxrc to change-install-name script before this script creation, meaning that it was simply overwritten later. See #22620. --- configure | 5 ++++- configure.in | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 86173493ff..5b4eea8051 100755 --- a/configure +++ b/configure @@ -27356,7 +27356,6 @@ $as_echo "$as_me: WARNING: XML library not built, cannot build wxrc" >&2;} USE_XML=0 else USE_XML=1 - echo "${HOST_PREFIX}install_name_tool \${changes} \${2}/wxrc-${WX_RELEASE}" >> change-install-names fi @@ -33938,6 +33937,10 @@ done for i in \${libnames} ; do ${HOST_PREFIX}install_name_tool \${changes} -id \${3}/\${i} \${1}/\${i} done + +if test -f "\${2}/wxrc-${WX_RELEASE}" ; then + ${HOST_PREFIX}install_name_tool \${changes} \${2}/wxrc-${WX_RELEASE} +fi EOF chmod +x change-install-names DYLIB_RPATH_INSTALL="\$(wx_top_builddir)/change-install-names \${DESTDIR}\${libdir} \${DESTDIR}\${bindir} \${libdir} \$(wx_top_builddir)/lib" diff --git a/configure.in b/configure.in index 9a52cdee65..15f0b38b7b 100644 --- a/configure.in +++ b/configure.in @@ -2975,7 +2975,6 @@ if test "$wxUSE_XML" != "yes"; then USE_XML=0 else USE_XML=1 - echo "${HOST_PREFIX}install_name_tool \${changes} \${2}/wxrc-${WX_RELEASE}" >> change-install-names fi @@ -4046,6 +4045,10 @@ done for i in \${libnames} ; do ${HOST_PREFIX}install_name_tool \${changes} -id \${3}/\${i} \${1}/\${i} done + +if test -f "\${2}/wxrc-${WX_RELEASE}" ; then + ${HOST_PREFIX}install_name_tool \${changes} \${2}/wxrc-${WX_RELEASE} +fi EOF chmod +x change-install-names DYLIB_RPATH_INSTALL="\$(wx_top_builddir)/change-install-names \${DESTDIR}\${libdir} \${DESTDIR}\${bindir} \${libdir} \$(wx_top_builddir)/lib"