solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Enable -Wextra for the CI builds

Browse source 
Try detecting more warnings that can be useful when building the
library.

Don't use -Wextra with gcc 4.8 which generates several completely
spurious warnings not generated by later compiler versions and which are
not worth fixing/working around.
This commit is contained in:
Vadim Zeitlin 2023-06-22 17:36:25 +02:00
parent e802eaa44d
commit 78760c3538
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
.github/workflows/ci.yml vendored
View file

@ -93,6 +93,7 @@ jobs:
compiler: g++-4.8 compiler: g++-4.8
container: ubuntu:18.04 container: ubuntu:18.04
configure_flags: --disable-shared configure_flags: --disable-shared
allow_extra_warnings: true
use_xvfb: true use_xvfb: true
- name: Ubuntu 18.04 wxGTK 3 compatible 3.0 - name: Ubuntu 18.04 wxGTK 3 compatible 3.0
runner: ubuntu-latest runner: ubuntu-latest
@ -233,7 +234,10 @@ jobs:
esac esac
if [ -z ${{ matrix.allow_warnings }} ]; then if [ -z ${{ matrix.allow_warnings }} ]; then
error_opts="-Werror $allow_warn_opt" if [ -z ${{ matrix.allow_extra_warnings }} ]; then
error_opts="-Wextra"
fi
error_opts="$error_opts -Werror $allow_warn_opt"
echo "wxMAKEFILE_ERROR_CXXFLAGS=$error_opts" >> $GITHUB_ENV echo "wxMAKEFILE_ERROR_CXXFLAGS=$error_opts" >> $GITHUB_ENV
echo "wxMAKEFILE_CXXFLAGS=$wxMAKEFILE_CXXFLAGS $error_opts" >> $GITHUB_ENV echo "wxMAKEFILE_CXXFLAGS=$wxMAKEFILE_CXXFLAGS $error_opts" >> $GITHUB_ENV
fi fi