solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Fix incorrect use of strncpy() in Scintilla DMIS lexer

Browse source 
This strncpy() was copying a buffer to itself, justifiably resulting in
a -Wrestrict from gcc-12 when using -O2.
This commit is contained in:
Vadim Zeitlin 2022-08-03 17:45:29 +02:00
parent 6fcca0c275
commit 74e7f5ccc9
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/stc/scintilla/lexers/LexDMIS.cxx
View file

@ -244,10 +244,10 @@ void SCI_METHOD LexerDMIS::Lex(Sci_PositionU startPos, Sci_Position lengthDoc, i
case SCE_DMIS_KEYWORD:
if (!setDMISWord.Contains(scCTX.ch)) {
char tmpStr[MAX_STR_LEN];
memset(tmpStr, 0, MAX_STR_LEN*sizeof(char));
scCTX.GetCurrent(tmpStr, (MAX_STR_LEN-1));
strncpy(tmpStr, this->UpperCase(tmpStr), (MAX_STR_LEN-1));
char tmpBuf[MAX_STR_LEN];
memset(tmpBuf, 0, MAX_STR_LEN*sizeof(char));
scCTX.GetCurrent(tmpBuf, (MAX_STR_LEN-1));
char* const tmpStr = this->UpperCase(tmpBuf);
if (this->m_minorWords.InList(tmpStr)) {
scCTX.ChangeState(SCE_DMIS_MINORWORD);