From 6832a58695049ddcf0feb159243a2b696cd4fd5b Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 26 Nov 2022 20:09:36 +0100 Subject: [PATCH] Fix inserting items into wxListCtrl in wxGenericPrintSetupDialog Set the ID before calling InsertItem(), otherwise it just fails (inserting an item without ID used to work in the generic version but never worked in the MSW one and was changed back in 2.9 to not work in the generic version neither for consistency). --- src/generic/prntdlgg.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/generic/prntdlgg.cpp b/src/generic/prntdlgg.cpp index 391c27d181..dcbb1af81e 100644 --- a/src/generic/prntdlgg.cpp +++ b/src/generic/prntdlgg.cpp @@ -501,7 +501,8 @@ void wxGenericPrintSetupDialog::Init(wxPrintData* data) item.SetMask( wxLIST_MASK_TEXT ); item.SetColumn( 1 ); item.SetText( _("Default printer") ); - item.SetId( m_printerListCtrl->InsertItem( item ) ); + item.SetId( 0 ); + m_printerListCtrl->InsertItem( item ); if (data->GetPrinterName().empty()) {