From 3ac39970b1e9c30c5d339d8a03d19d1d4fba504d Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Wed, 29 Mar 2023 13:30:50 +0200 Subject: [PATCH] Extend wxWebView test hack to all the builds The first unit test using wxWebView sometimes fails in other builds too, so try using the same hack as was previously used for the clang build for them as well. --- .github/workflows/ci.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 417691f075..0d23e6c53a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -362,12 +362,10 @@ jobs: echo 0 | sudo tee /proc/sys/kernel/core_uses_pid # This is exceedingly weird, but for some reason the first test using - # wxWebView in the build using clang under Ubuntu 20.04 fails (even - # if the timeout in the test is increased), so run it before really - # running the tests -- then they will succeed. - if [ '${{ matrix.compiler }}' = 'clang++-10' ]; then - xvfb-run -a -s '-screen 0 1600x1200x24' ./test_gui -c Title WebView >/dev/null 2>&1 || echo 'First wxWebView test failure ignored.' - fi + # wxWebView sometimes fails (even if the timeout in the test is + # increased), so run it before really running the tests -- then they + # will succeed. + xvfb-run -a -s '-screen 0 1600x1200x24' ./test_gui -c Title WebView >/dev/null 2>&1 || echo 'First wxWebView test failure ignored.' /bin/bash -o pipefail -c "xvfb-run -a -s '-screen 0 1600x1200x24' ./test_gui -d 1 $wx_tests_selection 2>&1 | tee -a test_gui.out" || rc=$? if [ -n "$rc" ]; then