solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Don't use wxPrintf() without format arguments

Browse source 
It could have been replaced with just wxPuts(), but using format
specifiers here instead of constructing the message by concatenating the
pieces makes the code more readable, so do this instead.

This avoids another warning about insecure format string use.
This commit is contained in:
Vadim Zeitlin 2022-11-23 03:16:12 +01:00
parent 09ad40e187
commit 31fba462d2
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
utils/wxrc/wxrc.cpp
View file

@ -417,7 +417,7 @@ wxArrayString XmlResApp::PrepareTempFiles()
for (size_t i = 0; i < parFiles.GetCount(); i++)
{
if (flagVerbose)
wxPrintf(wxT("processing ") + parFiles[i] + wxT("...\n"));
wxPrintf(wxT("processing %s...\n"), parFiles[i]);
wxXmlDocument doc;
@ -529,7 +529,7 @@ void XmlResApp::FindFilesInXML(wxXmlNode *node, wxArrayString& flist, const wxSt
fullname = inputPath + wxFILE_SEP_PATH + n->GetContent();
if (flagVerbose)
wxPrintf(wxT("adding ") + fullname + wxT("...\n"));
wxPrintf(wxT("adding %s...\n"), fullname);
wxString filename = GetInternalFileName(n->GetContent(), flist);
n->SetContent(filename);
@ -569,7 +569,7 @@ void XmlResApp::MakePackageZIP(const wxArrayString& flist)
files.RemoveLast();
if (flagVerbose)
wxPrintf(wxT("compressing ") + parOutput + wxT("...\n"));
wxPrintf(wxT("compressing %s...\n"), parOutput);
wxString cwd = wxGetCwd();
wxSetWorkingDirectory(parOutputPath);
@ -639,7 +639,7 @@ void XmlResApp::MakePackageCPP(const wxArrayString& flist)
unsigned i;
if (flagVerbose)
wxPrintf(wxT("creating C++ source file ") + parOutput + wxT("...\n"));
wxPrintf(wxT("creating C++ source file %s...\n"), parOutput);
file.Write(""
"//\n"
@ -797,7 +797,7 @@ void XmlResApp::MakePackagePython(const wxArrayString& flist)
unsigned i;
if (flagVerbose)
wxPrintf(wxT("creating Python source file ") + parOutput + wxT("...\n"));
wxPrintf(wxT("creating Python source file %s...\n"), parOutput);
file.Write(
"#\n"
@ -881,7 +881,7 @@ ExtractedStrings XmlResApp::FindStrings()
for (size_t i = 0; i < parFiles.GetCount(); i++)
{
if (flagVerbose)
wxPrintf(wxT("processing ") + parFiles[i] + wxT("...\n"));
wxPrintf(wxT("processing %s...\n"), parFiles[i]);
wxXmlDocument doc;
if (!doc.Load(parFiles[i]))