solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Remove unnecessary variable in dataview sample

Browse source 
No real changes, just simplify the code.

Closes #23687.
This commit is contained in:
ollydbg 2023-07-08 01:28:00 +01:00 • committed by Vadim Zeitlin
parent 86e394beb2
commit 25ff038c80
2 changed files with 4 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

20
samples/dataview/mymodels.cpp
View file

@ -47,8 +47,6 @@ MyMusicTreeModel::MyMusicTreeModel()
m_classical->Append( new MyMusicTreeModelNode( m_classical, "German Requiem",
"Johannes Brahms", 1868 ) );
m_root->Append( m_classical );
m_classicalMusicIsKnownToControl = false;
}
wxString MyMusicTreeModel::GetTitle( const wxDataViewItem &item ) const
@ -100,14 +98,10 @@ void MyMusicTreeModel::AddToClassical( const wxString &title, const wxString &ar
new MyMusicTreeModelNode( m_classical, title, artist, year );
m_classical->Append( child_node );
// FIXME: what's m_classicalMusicIsKnownToControl for?
if (m_classicalMusicIsKnownToControl)
{
// notify control
wxDataViewItem child( (void*) child_node );
wxDataViewItem parent( (void*) m_classical );
ItemAdded( parent, child );
}
// notify control
wxDataViewItem child( (void*) child_node );
wxDataViewItem parent( (void*) m_classical );
ItemAdded( parent, child );
}
void MyMusicTreeModel::Delete( const wxDataViewItem &item )
@ -307,12 +301,6 @@ unsigned int MyMusicTreeModel::GetChildren( const wxDataViewItem &parent,
return 1;
}
if (node == m_classical)
{
MyMusicTreeModel* model = const_cast<MyMusicTreeModel*>(this);
model->m_classicalMusicIsKnownToControl = true;
}
if (node->GetChildCount() == 0)
{
return 0;

3
samples/dataview/mymodels.h
View file

@ -160,9 +160,6 @@ private:
MyMusicTreeModelNode* m_pop;
MyMusicTreeModelNode* m_classical;
MyMusicTreeModelNode* m_ninth;
// ??
bool m_classicalMusicIsKnownToControl;
};