solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Use custom painting in wxStaticBox even with double buffering on

Browse source 
Unfortunately the fact that is on when wxStaticBox is created doesn't
guarantee that it remains on when it is painted later, as
MSWDisableComposited() could be called in the meanwhile, breaking the
redraw of the box.

Conservatively fix this by just always painting the box ourselves, but
mention a possibly better solution.
This commit is contained in:
Vadim Zeitlin 2023-02-21 16:31:34 +00:00
parent 674bfb5e5a
commit 18002cf6ca
1 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/msw/statbox.cpp
View file

@ -106,13 +106,18 @@ bool wxStaticBox::MSWGetDarkModeSupport(MSWDarkModeSupport& support) const
bool wxStaticBox::ShouldUseCustomPaint() const
{
// When not using double buffering, we paint the box ourselves by default
// because using the standard control default WM_PAINT handler results in
// awful flicker. However this can be disabled by setting a system option
// which can be useful if the application paints on the box itself (which
// should be avoided, but some existing code does it).
return !IsDoubleBuffered() &&
!wxSystemOptions::IsFalse(wxT("msw.staticbox.optimized-paint"));
// We currently always custom paint the box because we can't rely on double
// buffering remaining on even if it is on now, i.e. IsDoubleBuffered()
// could return true right but WS_EX_COMPOSITED could get turned off later
// because MSWDisableComposited() is called and this would make default
// WM_PAINT not work correctly any longer. A probably better solution would
// be to notify all windows from MSWDisableComposited() when the double
// buffered status changes.
//
// Still allow be disabling this by setting a system option which can be
// useful if the application paints on the box itself (which should be
// avoided, but some existing code does it).
return !wxSystemOptions::IsFalse(wxT("msw.staticbox.optimized-paint"));
}
void wxStaticBox::UseCustomPaint()