solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Fix assert in webview sample when viewing pages without a title.

Browse source 
Trying to append a menu item with empty label resulted in an assert (at least
under wxGTK but probably elsewhere too), and in any case wasn't very useful,
so use "(untitled)" instead in this case.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72174 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin 2012-07-23 15:03:09 +00:00
parent c3980646f6
commit 14a0b47dff
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
samples/webview/webview.cpp
View file

@ -641,7 +641,10 @@ void WebFrame::OnToolsClicked(wxCommandEvent& WXUNUSED(evt))
wxCommandEventHandler(WebFrame::OnHistory), NULL, this );
}
item = m_tools_history_menu->AppendRadioItem(wxID_ANY, m_browser->GetCurrentTitle());
wxString title = m_browser->GetCurrentTitle();
if ( title.empty() )
title = "(untitled)";
item = m_tools_history_menu->AppendRadioItem(wxID_ANY, title);
item->Check();
//No need to connect the current item