solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Don't expose internal strings to translation in samples

Browse source 
Remove _() around string which it doesn't make sense to translate in the
sockets sample.

This doesn't actually change anything as this sample doesn't use
translations in any case, but still show a good example.

Closes #23362.
This commit is contained in:
Blake Madden 2023-03-19 08:11:49 -04:00 • committed by Vadim Zeitlin
parent 35a8d0f908
commit 11358d7dcc
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
samples/sockets/client.cpp
View file

@ -325,7 +325,7 @@ void MyFrame::OpenConnection(wxSockAddress::Family family)
wxString hostname = wxGetTextFromUser(
_("Enter the address of the wxSocket demo server:"),
_("Connect ..."),
_("localhost"));
"localhost");
if ( hostname.empty() )
return;

10
samples/sockets/server.cpp
View file

@ -381,12 +381,12 @@ void MyFrame::Test3(wxSocketBase *sock)
void MyFrame::OnServerEvent(wxSocketEvent& event)
{
wxString s = _("OnServerEvent: ");
wxString s = "OnServerEvent: ";
wxSocketBase *sock;
switch(event.GetSocketEvent())
{
case wxSOCKET_CONNECTION : s.Append(_("wxSOCKET_CONNECTION\n")); break;
case wxSOCKET_CONNECTION : s.Append("wxSOCKET_CONNECTION\n"); break;
default : s.Append(_("Unexpected event !\n")); break;
}
@ -428,14 +428,14 @@ void MyFrame::OnServerEvent(wxSocketEvent& event)
void MyFrame::OnSocketEvent(wxSocketEvent& event)
{
wxString s = _("OnSocketEvent: ");
wxString s = "OnSocketEvent: ";
wxSocketBase *sock = event.GetSocket();
// First, print a message
switch(event.GetSocketEvent())
{
case wxSOCKET_INPUT : s.Append(_("wxSOCKET_INPUT\n")); break;
case wxSOCKET_LOST : s.Append(_("wxSOCKET_LOST\n")); break;
case wxSOCKET_INPUT : s.Append("wxSOCKET_INPUT\n"); break;
case wxSOCKET_LOST : s.Append("wxSOCKET_LOST\n"); break;
default : s.Append(_("Unexpected event !\n")); break;
}