solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Initialize wxAuiTabCtrl members in their declarations

Browse source 
Ensure that all of them are initialized, including m_clickTab, which
didn't seem to be always initialized before.

No real changes (as m_clickTab doesn't seem to have been used before it
was initialized).
This commit is contained in:
Vadim Zeitlin 2023-11-06 00:05:50 +01:00
parent bd7b333a87
commit 0fd15e405f
2 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
include/wx/aui/auibook.h
View file

@ -236,11 +236,11 @@ protected:
protected:
wxPoint m_clickPt;
wxWindow* m_clickTab;
bool m_isDragging;
wxAuiTabContainerButton* m_hoverButton;
wxAuiTabContainerButton* m_pressedButton;
wxPoint m_clickPt = wxDefaultPosition;
wxWindow* m_clickTab = nullptr;
bool m_isDragging = false;
wxAuiTabContainerButton* m_hoverButton = nullptr;
wxAuiTabContainerButton* m_pressedButton = nullptr;
void SetHoverTab(wxWindow* wnd);

4
src/aui/auibook.cpp
View file

@ -1013,10 +1013,6 @@ wxAuiTabCtrl::wxAuiTabCtrl(wxWindow* parent,
long style) : wxControl(parent, id, pos, size, style)
{
SetName(wxT("wxAuiTabCtrl"));
m_clickPt = wxDefaultPosition;
m_isDragging = false;
m_hoverButton = nullptr;
m_pressedButton = nullptr;
}
wxAuiTabCtrl::~wxAuiTabCtrl()