solemnwarning/wxwidgets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Stop disabling deprecation warnings when compiling wxGTK

Browse source 
Don't use blanket warning suppression, as this suppresses even warnings
about using our own deprecated API which is undesirable.
This commit is contained in:
Vadim Zeitlin 2022-09-23 01:42:24 +02:00
parent 0859c01035
commit 097abf20b9
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
build/cmake/functions.cmake
View file

@ -129,8 +129,8 @@ function(wx_set_common_target_properties target_name)
-Woverloaded-virtual
)
if(WXOSX_COCOA OR WXGTK3)
# when building using GTK+ 3 or Cocoa we currently get tons of deprecation
if(WXOSX_COCOA)
# when building using Cocoa we currently get tons of deprecation
# warnings from the standard headers -- disable them as we already know
# that they're deprecated but we still have to use them to support older
# toolkit versions and leaving this warning enabled prevents seeing any

2
configure vendored
View file

@ -42928,7 +42928,7 @@ esac
CXXWARNINGS="$CXXWARNINGS -Wno-deprecated-declarations -Wno-narrowing -Wno-write-strings"
fi
if test "$WXGTK4" != 1 -a \( "$WXGTK3" = 1 -o "$wxUSE_MAC" = 1 \) ; then
if test "$wxUSE_MAC" = 1 ; then
CXXWARNINGS="$CXXWARNINGS -Wno-deprecated-declarations"
OBJCXXFLAGS="$OBJCXXFLAGS -Wno-deprecated-declarations"

4
configure.in
View file

@ -8183,12 +8183,12 @@ elif test "$GXX" = yes ; then
CXXWARNINGS="$CXXWARNINGS -Wno-deprecated-declarations -Wno-narrowing -Wno-write-strings"
fi
dnl when building using GTK+ 3 or Cocoa we currently get tons of deprecation
dnl when building using Cocoa we currently get tons of deprecation
dnl warnings from the standard headers -- disable them as we already know
dnl that they're deprecated but we still have to use them to support older
dnl toolkit versions and leaving this warning enabled prevents seeing any
dnl other ones
if test "$WXGTK4" != 1 -a \( "$WXGTK3" = 1 -o "$wxUSE_MAC" = 1 \) ; then
if test "$wxUSE_MAC" = 1 ; then
CXXWARNINGS="$CXXWARNINGS -Wno-deprecated-declarations"
dnl CXXWARNINGS is not used for Objective-C++ code compilation, but we